wangchunlin
/
cvat
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix more ESLint errors (#5619)

Browse Source
main
Roman Donchenko 3 years ago committed by GitHub
parent 54e3198602
commit 41c6728528
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
13 changed files with 27 additions and 29 deletions
Show Stats Download Patch File Download Diff File

2
.eslintrc.js
Unescape Escape View File

@ -39,7 +39,7 @@ module.exports = {
'func-names': 0,
'valid-typeof': 0,
'no-useless-constructor': 0, // sometimes constructor is necessary to generate right documentation in cvat-core
'quotes': ['error', 'single'],
'quotes': ['error', 'single', { "avoidEscape": true }],
'lines-between-class-members': 0,
'class-methods-use-this': 0,
'no-underscore-dangle': ['error', { allowAfterThis: true }],

4
cvat-core/tests/api/projects.js
Unescape Escape View File

@ -97,7 +97,7 @@ describe('Feature: save a project', () => {
const labelsLength = result[0].labels.length;
const newLabel = new window.cvat.classes.Label({
name: 'My boss\'s car',
name: "My boss's car",
attributes: [
{
default_value: 'false',
@ -117,7 +117,7 @@ describe('Feature: save a project', () => {
});
expect(result[0].labels).toHaveLength(labelsLength + 1);
const appendedLabel = result[0].labels.filter((el) => el.name === 'My boss\'s car');
const appendedLabel = result[0].labels.filter((el) => el.name === "My boss's car");
expect(appendedLabel).toHaveLength(1);
expect(appendedLabel[0].attributes).toHaveLength(1);
expect(appendedLabel[0].attributes[0].name).toBe('parked');

6
cvat-core/tests/api/tasks.js
Unescape Escape View File

@ -124,7 +124,7 @@ describe('Feature: save a task', () => {
const labelsLength = result[0].labels.length;
const newLabel = new window.cvat.classes.Label({
name: 'My boss\'s car',
name: "My boss's car",
attributes: [
{
default_value: 'false',
@ -144,7 +144,7 @@ describe('Feature: save a task', () => {
});
expect(result[0].labels).toHaveLength(labelsLength + 1);
const appendedLabel = result[0].labels.filter((el) => el.name === 'My boss\'s car');
const appendedLabel = result[0].labels.filter((el) => el.name === "My boss's car");
expect(appendedLabel).toHaveLength(1);
expect(appendedLabel[0].attributes).toHaveLength(1);
expect(appendedLabel[0].attributes[0].name).toBe('parked');
@ -158,7 +158,7 @@ describe('Feature: save a task', () => {
name: 'New Task',
labels: [
{
name: 'My boss\'s car',
name: "My boss's car",
attributes: [
{
default_value: 'false',

18
cvat-ui/src/components/move-task-modal/label-mapper-item.tsx
Unescape Escape View File

@ -48,11 +48,10 @@ export default function LabelMapperItem(props: LabelMapperItemProps): JSX.Elemen
className='cvat-move-task-label-mapper-item-select'
disabled={typeof projectLabels === 'undefined'}
value={value.newLabelName || ''}
onChange={(_value) =>
onChange({
...value,
newLabelName: _value as string,
})}
onChange={(_value) => onChange({
...value,
newLabelName: _value as string,
})}
>
{projectLabels
?.filter((_label) => !labelNames.includes(_label.name))
@ -67,11 +66,10 @@ export default function LabelMapperItem(props: LabelMapperItemProps): JSX.Elemen
<Checkbox
disabled
checked={value.clearAttributes}
onChange={(_value) =>
onChange({
...value,
clearAttributes: _value.target.checked,
})}
onChange={(_value) => onChange({
...value,
clearAttributes: _value.target.checked,
})}
>
Clear attributes
</Checkbox>

2
cvat-ui/src/components/project-page/details.tsx
Unescape Escape View File

@ -28,7 +28,7 @@ export default function DetailsComponent(props: DetailsComponentProps): JSX.Elem
const [projectName, setProjectName] = useState(project.name);
return (
<div cvat-project-id={project.id} className='cvat-project-details'>
<div data-cvat-project-id={project.id} className='cvat-project-details'>
<Row>
<Col>
<Title

4
cvat-ui/src/utils/opencv-wrapper/histogram-equalization.ts
Unescape Escape View File

@ -76,7 +76,7 @@ export default class HistogramEqualizationImplementation implements HistogramEqu
}
}
private hashedFrame(frameNumber: number): ImageData|null {
private hashedFrame(frameNumber: number): ImageData | null {
const hashed = this.histHash.find((_hashed) => _hashed.frameNumber === frameNumber);
if (hashed) {
hashed.timestamp = Date.now();
@ -84,7 +84,7 @@ export default class HistogramEqualizationImplementation implements HistogramEqu
return hashed?.frameData || null;
}
private hashFrame(frameData:ImageData, frameNumber:number):void{
private hashFrame(frameData: ImageData, frameNumber: number): void {
if (this.histHash.length >= this.bufferSize) {
const leastRecentlyUsed = this.histHash[0];
const currentTimestamp = Date.now();

6
tests/cypress/integration/actions_organizations/case_113_new_organization_pipeline.js
Unescape Escape View File

@ -189,14 +189,14 @@ context('New organization pipeline.', () => {
cy.closeNotification('.cvat-notification-notice-leave-organization-failed');
});
it('The second user login. The user is able to see the organization, can\'t see the task.', () => {
it("The second user login. The user is able to see the organization, can't see the task.", () => {
cy.logout();
cy.login(secondUserName, secondUser.password);
cy.checkOrganizationExists(organizationParams.shortName);
cy.contains('.cvat-item-task-name', taskName).should('not.exist');
});
it('The second user activates the organization, can\'t see the project because it is not assigned to him.', () => {
it("The second user activates the organization, can't see the project because it is not assigned to him.", () => {
cy.activateOrganization(organizationParams.shortName);
cy.goToProjectsList();
cy.contains('.cvat-projects-project-item-title', project.name).should('not.exist');
@ -232,7 +232,7 @@ context('New organization pipeline.', () => {
});
});
it('Logout, the third user login. The user does not see the project, the task. The user can\'t open the job using direct link.', () => {
it("Logout, the third user login. The user does not see the project, the task. The user can't open the job using direct link.", () => {
cy.logout(secondUserName);
cy.login(thirdUserName, thirdUser.password);
cy.contains('.cvat-item-task-name', taskName).should('not.exist');

2
tests/cypress/integration/actions_projects_models/case_57_project_label_deleting_feature.js
Unescape Escape View File

@ -31,7 +31,7 @@ context('Delete a label from a project.', () => {
function getProjectID() {
cy.contains('.cvat-project-name', projectName)
.parents('.cvat-project-details')
.should('have.attr', 'cvat-project-id')
.should('have.attr', 'data-cvat-project-id')
.then(($projectID) => {
projectID = $projectID;
});

2
tests/cypress/integration/actions_projects_models/registration_involved/base_actions_project_task_user.js
Unescape Escape View File

@ -47,7 +47,7 @@ context('Base actions on the project', () => {
function getProjectID(myProjectName) {
cy.contains('.cvat-project-name', myProjectName)
.parents('.cvat-project-details')
.should('have.attr', 'cvat-project-id')
.should('have.attr', 'data-cvat-project-id')
.then(($projectID) => {
projectID = $projectID;
});

2
tests/cypress/integration/actions_tasks3/case_19_all_image_rotate_features.js
Unescape Escape View File

@ -40,7 +40,7 @@ context('Rotate all images feature.', () => {
imageRotate('anticlockwise', 270);
});
it('Go to the next frame. It wasn\'t rotated.', () => {
it("Go to the next frame. It wasn't rotated.", () => {
cy.get('.cvat-player-next-button').click();
checkFrameNum(1);
checkDegRotate(0);

4
tests/cypress/integration/issues_prs/issue_1882_polygon_interpolation.js
Unescape Escape View File

@ -6,7 +6,7 @@
import { taskName, labelName } from '../../support/const';
context('The points of the previous polygon mustn\'t appear while polygon\'s interpolation.', () => {
context("The points of the previous polygon mustn't appear while polygon's interpolation.", () => {
const issueId = '1882';
const createPolygonTrack = {
reDraw: false,
@ -48,7 +48,7 @@ context('The points of the previous polygon mustn\'t appear while polygon\'s int
.trigger('mousemove', { force: true })
.trigger('keydown', { keyCode: keyCodeN, code: 'KeyN', shiftKey: true })
.trigger('keyup', {
force: true, keyCode: keyCodeN, code: 'KeyN', shiftKey: true
force: true, keyCode: keyCodeN, code: 'KeyN', shiftKey: true,
});
cy.createPolygon(reDrawPolygonTrack);
});

2
tests/cypress/integration/issues_prs/issue_1886_point_coordinates_not_duplicated.js
Unescape Escape View File

@ -6,7 +6,7 @@
import { taskName, advancedConfigurationParams, labelName } from '../../support/const';
context('Point coordinates are not duplicated while polygon\'s interpolation.', () => {
context("Point coordinates are not duplicated while polygon's interpolation.", () => {
const issueId = '1886';
const pointsCoordinates = [];
const createPolygonTrack = {

2
tests/cypress/support/const.js
Unescape Escape View File

@ -44,7 +44,7 @@ it('Prepare to testing', () => {
listItems.push(collection[i].innerText);
}
if (listItems.indexOf(taskName) === -1) {
cy.task('log', 'A task doesn\'t exist. Creating.');
cy.task('log', "A task doesn't exist. Creating.");
cy.imageGenerator(imagesFolder, imageFileName, width, height, color, posX, posY, labelName, imagesCount);
cy.createZipArchive(directoryToArchive, archivePath);
cy.createAnnotationTask(

Write Preview
Loading…
Cancel
Save