From 85f9fbdb3a6568a338223efa7803b73454ab0f84 Mon Sep 17 00:00:00 2001 From: Maxim Zhiltsov Date: Fri, 4 Nov 2022 17:00:22 +0300 Subject: [PATCH] Fix linter warnings (#5188) --- cvat/apps/engine/mixins.py | 1 + cvat/apps/engine/views.py | 39 ++++++++++++++++---------------- cvat/apps/organizations/views.py | 12 ++++------ 3 files changed, 25 insertions(+), 27 deletions(-) diff --git a/cvat/apps/engine/mixins.py b/cvat/apps/engine/mixins.py index 8dd38a62..4c59f981 100644 --- a/cvat/apps/engine/mixins.py +++ b/cvat/apps/engine/mixins.py @@ -329,6 +329,7 @@ class SerializeMixin: class CreateModelMixin(mixins.CreateModelMixin): def perform_create(self, serializer, **kwargs): serializer.save(**kwargs) + signal_create.send(self, instance=serializer.instance) class PartialUpdateModelMixin: diff --git a/cvat/apps/engine/views.py b/cvat/apps/engine/views.py index 53b4c763..61be2a36 100644 --- a/cvat/apps/engine/views.py +++ b/cvat/apps/engine/views.py @@ -306,12 +306,10 @@ class ProjectViewSet(viewsets.GenericViewSet, mixins.ListModelMixin, queryset = perm.filter(queryset) return queryset - def perform_create(self, serializer): - super().perform_create( - serializer, - owner=self.request.user, - organization=self.request.iam_context['organization'] - ) + def perform_create(self, serializer, **kwargs): + kwargs.setdefault('owner', self.request.user) + kwargs.setdefault('organization', self.request.iam_context['organization']) + super().perform_create(serializer, **kwargs) @extend_schema( summary='Method returns information of the tasks of the project with the selected id', @@ -814,12 +812,11 @@ class TaskViewSet(viewsets.GenericViewSet, mixins.ListModelMixin, if updated_instance.project: updated_instance.project.save() - def perform_create(self, serializer): - super().perform_create( - serializer, - owner=self.request.user, - organization=self.request.iam_context['organization'] - ) + def perform_create(self, serializer, **kwargs): + kwargs.setdefault('owner', self.request.user) + kwargs.setdefault('organization', self.request.iam_context['organization']) + super().perform_create(serializer, **kwargs) + if serializer.instance.project: db_project = serializer.instance.project db_project.save() @@ -1741,8 +1738,9 @@ class IssueViewSet(viewsets.GenericViewSet, mixins.ListModelMixin, else: return IssueWriteSerializer - def perform_create(self, serializer): - super().perform_create(serializer, owner=self.request.user) + def perform_create(self, serializer, **kwargs): + kwargs.setdefault('owner', self.request.user) + super().perform_create(serializer, **kwargs) @extend_schema(summary='The action returns all comments of a specific issue', responses=CommentReadSerializer(many=True)) # Duplicate to still get 'list' op. name @@ -1816,8 +1814,9 @@ class CommentViewSet(viewsets.GenericViewSet, mixins.ListModelMixin, else: return CommentWriteSerializer - def perform_create(self, serializer): - super().perform_create(serializer, owner=self.request.user) + def perform_create(self, serializer, **kwargs): + kwargs.setdefault('owner', self.request.user) + super().perform_create(serializer, **kwargs) @extend_schema(tags=['users']) @extend_schema_view( @@ -1964,10 +1963,10 @@ class CloudStorageViewSet(viewsets.GenericViewSet, mixins.ListModelMixin, raise ValidationError('Unsupported type of cloud provider') return queryset - def perform_create(self, serializer): - serializer.save( - owner=self.request.user, - organization=self.request.iam_context['organization']) + def perform_create(self, serializer, **kwargs): + kwargs.setdefault('owner', self.request.user) + kwargs.setdefault('organization', self.request.iam_context['organization']) + super().perform_create(serializer, **kwargs) def perform_destroy(self, instance): cloud_storage_dirname = instance.get_storage_dirname() diff --git a/cvat/apps/organizations/views.py b/cvat/apps/organizations/views.py index 3e4da2f3..e739d791 100644 --- a/cvat/apps/organizations/views.py +++ b/cvat/apps/organizations/views.py @@ -201,13 +201,11 @@ class InvitationViewSet(viewsets.GenericViewSet, permission = InvitationPermission.create_scope_list(self.request) return permission.filter(queryset) - def perform_create(self, serializer): - extra_kwargs = { - 'owner': self.request.user, - 'key': get_random_string(length=64), - 'organization': self.request.iam_context['organization'] - } - super().perform_create(serializer, **extra_kwargs) + def perform_create(self, serializer, **kwargs): + kwargs.setdefault('owner', self.request.user) + kwargs.setdefault('organization', self.request.iam_context['organization']) + kwargs['key'] = get_random_string(length=64) + super().perform_create(serializer, **kwargs) def perform_update(self, serializer): if 'accepted' in self.request.query_params: