From a82419671822e8fd9132bdbacb1f8f9dbe2dccdb Mon Sep 17 00:00:00 2001 From: Rodrigo Berriel Date: Mon, 5 Sep 2022 11:08:56 -0300 Subject: [PATCH] Add support for Oracle OCI Buckets (#4876) --- CHANGELOG.md | 1 + .../create-cloud-storage-page/cloud-storage-form.tsx | 2 +- cvat/apps/engine/models.py | 6 +++--- cvat/apps/engine/serializers.py | 4 ++-- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 26b0e63a..363842f8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,7 @@ Skeleton (), () - Added confirmation when remove a track () - [COCO Keypoints](https://cocodataset.org/#keypoints-2020) format support () +- Support for Oracle OCI Buckets () ### Changed - Bumped nuclio version to 1.8.14 diff --git a/cvat-ui/src/components/create-cloud-storage-page/cloud-storage-form.tsx b/cvat-ui/src/components/create-cloud-storage-page/cloud-storage-form.tsx index 32e1ef82..01f161a6 100644 --- a/cvat-ui/src/components/create-cloud-storage-page/cloud-storage-form.tsx +++ b/cvat-ui/src/components/create-cloud-storage-page/cloud-storage-form.tsx @@ -346,7 +346,7 @@ export default function CreateCloudStorageForm(props: Props): JSX.Element { {...internalCommonProps} > setSecretKeyVisibility(true)} onFocus={() => onFocusCredentialsItem('secretKey', 'secret_key')} diff --git a/cvat/apps/engine/models.py b/cvat/apps/engine/models.py index 3f882935..bdcde0e5 100644 --- a/cvat/apps/engine/models.py +++ b/cvat/apps/engine/models.py @@ -743,9 +743,9 @@ class CloudStorage(models.Model): # restrictions: # AWS bucket name, Azure container name - 63, Google bucket name - 63 without dots and 222 with dots # https://cloud.google.com/storage/docs/naming-buckets#requirements - # AWS access key id - 20 - # AWS secret access key - 40 - # AWS temporary session tocken - None + # AWS access key id - 20, Oracle OCI access key id - 40 + # AWS secret access key - 40, Oracle OCI secret key id - 44 + # AWS temporary session token - None # The size of the security token that AWS STS API operations return is not fixed. # We strongly recommend that you make no assumptions about the maximum size. # The typical token size is less than 4096 bytes, but that can vary. diff --git a/cvat/apps/engine/serializers.py b/cvat/apps/engine/serializers.py index 81a06ee8..5d2bb507 100644 --- a/cvat/apps/engine/serializers.py +++ b/cvat/apps/engine/serializers.py @@ -1150,8 +1150,8 @@ class CloudStorageReadSerializer(serializers.ModelSerializer): class CloudStorageWriteSerializer(serializers.ModelSerializer): owner = BasicUserSerializer(required=False) session_token = serializers.CharField(max_length=440, allow_blank=True, required=False) - key = serializers.CharField(max_length=20, allow_blank=True, required=False) - secret_key = serializers.CharField(max_length=40, allow_blank=True, required=False) + key = serializers.CharField(max_length=40, allow_blank=True, required=False) + secret_key = serializers.CharField(max_length=44, allow_blank=True, required=False) key_file = serializers.FileField(required=False) account_name = serializers.CharField(max_length=24, allow_blank=True, required=False) manifests = ManifestSerializer(many=True, default=[])