FIX: Remove a possibly duplicated encodeURI() (Issue #4428) (#4947)

* FIX: Remove possibly duplicated encodeURI() to prevent double encode non-ascii path (Issue #4428 Cannot connect file share,cannot recognize non-ascii path)

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Boris Sekachev <sekachev.bs@gmail.com>
main
rhee-elten 3 years ago committed by GitHub
parent f018a76694
commit 15565cb952
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -19,7 +19,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- TDB - TDB
### Fixed ### Fixed
- TDB - Removed a possibly duplicated encodeURI() calls in `server-proxy.ts` to prevent doubly encoding
non-ascii paths while adding files from "Connected file share" (issue #4428)
### Security ### Security
- TDB - TDB

@ -243,13 +243,12 @@ class ServerProxy {
async function share(directoryArg) { async function share(directoryArg) {
const { backendAPI } = config; const { backendAPI } = config;
const directory = encodeURI(directoryArg);
let response = null; let response = null;
try { try {
response = await Axios.get(`${backendAPI}/server/share`, { response = await Axios.get(`${backendAPI}/server/share`, {
proxy: config.proxy, proxy: config.proxy,
params: { directory }, params: { directory: directoryArg },
}); });
} catch (errorData) { } catch (errorData) {
throw generateError(errorData); throw generateError(errorData);

Loading…
Cancel
Save