Fix linter warnings (#5188)

main
Maxim Zhiltsov 3 years ago committed by GitHub
parent bca5bb6cae
commit 85f9fbdb3a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -329,6 +329,7 @@ class SerializeMixin:
class CreateModelMixin(mixins.CreateModelMixin):
def perform_create(self, serializer, **kwargs):
serializer.save(**kwargs)
signal_create.send(self, instance=serializer.instance)
class PartialUpdateModelMixin:

@ -306,12 +306,10 @@ class ProjectViewSet(viewsets.GenericViewSet, mixins.ListModelMixin,
queryset = perm.filter(queryset)
return queryset
def perform_create(self, serializer):
super().perform_create(
serializer,
owner=self.request.user,
organization=self.request.iam_context['organization']
)
def perform_create(self, serializer, **kwargs):
kwargs.setdefault('owner', self.request.user)
kwargs.setdefault('organization', self.request.iam_context['organization'])
super().perform_create(serializer, **kwargs)
@extend_schema(
summary='Method returns information of the tasks of the project with the selected id',
@ -814,12 +812,11 @@ class TaskViewSet(viewsets.GenericViewSet, mixins.ListModelMixin,
if updated_instance.project:
updated_instance.project.save()
def perform_create(self, serializer):
super().perform_create(
serializer,
owner=self.request.user,
organization=self.request.iam_context['organization']
)
def perform_create(self, serializer, **kwargs):
kwargs.setdefault('owner', self.request.user)
kwargs.setdefault('organization', self.request.iam_context['organization'])
super().perform_create(serializer, **kwargs)
if serializer.instance.project:
db_project = serializer.instance.project
db_project.save()
@ -1741,8 +1738,9 @@ class IssueViewSet(viewsets.GenericViewSet, mixins.ListModelMixin,
else:
return IssueWriteSerializer
def perform_create(self, serializer):
super().perform_create(serializer, owner=self.request.user)
def perform_create(self, serializer, **kwargs):
kwargs.setdefault('owner', self.request.user)
super().perform_create(serializer, **kwargs)
@extend_schema(summary='The action returns all comments of a specific issue',
responses=CommentReadSerializer(many=True)) # Duplicate to still get 'list' op. name
@ -1816,8 +1814,9 @@ class CommentViewSet(viewsets.GenericViewSet, mixins.ListModelMixin,
else:
return CommentWriteSerializer
def perform_create(self, serializer):
super().perform_create(serializer, owner=self.request.user)
def perform_create(self, serializer, **kwargs):
kwargs.setdefault('owner', self.request.user)
super().perform_create(serializer, **kwargs)
@extend_schema(tags=['users'])
@extend_schema_view(
@ -1964,10 +1963,10 @@ class CloudStorageViewSet(viewsets.GenericViewSet, mixins.ListModelMixin,
raise ValidationError('Unsupported type of cloud provider')
return queryset
def perform_create(self, serializer):
serializer.save(
owner=self.request.user,
organization=self.request.iam_context['organization'])
def perform_create(self, serializer, **kwargs):
kwargs.setdefault('owner', self.request.user)
kwargs.setdefault('organization', self.request.iam_context['organization'])
super().perform_create(serializer, **kwargs)
def perform_destroy(self, instance):
cloud_storage_dirname = instance.get_storage_dirname()

@ -201,13 +201,11 @@ class InvitationViewSet(viewsets.GenericViewSet,
permission = InvitationPermission.create_scope_list(self.request)
return permission.filter(queryset)
def perform_create(self, serializer):
extra_kwargs = {
'owner': self.request.user,
'key': get_random_string(length=64),
'organization': self.request.iam_context['organization']
}
super().perform_create(serializer, **extra_kwargs)
def perform_create(self, serializer, **kwargs):
kwargs.setdefault('owner', self.request.user)
kwargs.setdefault('organization', self.request.iam_context['organization'])
kwargs['key'] = get_random_string(length=64)
super().perform_create(serializer, **kwargs)
def perform_update(self, serializer):
if 'accepted' in self.request.query_params:

Loading…
Cancel
Save