Remove limit on maximum number of manifest files that can be added for cloud storage (#5660)

main
Maria Khrustaleva 3 years ago committed by GitHub
parent 4df7c4c208
commit ba49fc4029
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -43,7 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- TDB - TDB
### Removed ### Removed
- TDB - Limit on the maximum number of manifest files that can be added for cloud storage (<https://github.com/opencv/cvat/pull/5660>)
### Fixed ### Fixed
- Helm: Empty password for Redis (<https://github.com/opencv/cvat/pull/5520>) - Helm: Empty password for Redis (<https://github.com/opencv/cvat/pull/5520>)

@ -1,6 +1,6 @@
{ {
"name": "cvat-ui", "name": "cvat-ui",
"version": "1.48.0", "version": "1.48.1",
"description": "CVAT single-page application", "description": "CVAT single-page application",
"main": "src/index.tsx", "main": "src/index.tsx",
"scripts": { "scripts": {

@ -1,8 +1,9 @@
// Copyright (C) 2021-2022 Intel Corporation // Copyright (C) 2021-2022 Intel Corporation
// Copyright (C) 2023 CVAT.ai Corporation
// //
// SPDX-License-Identifier: MIT // SPDX-License-Identifier: MIT
import React, { useEffect, useRef, useState } from 'react'; import React, { useEffect } from 'react';
import { DeleteOutlined, PlusCircleOutlined, QuestionCircleOutlined } from '@ant-design/icons'; import { DeleteOutlined, PlusCircleOutlined, QuestionCircleOutlined } from '@ant-design/icons';
import Button from 'antd/lib/button'; import Button from 'antd/lib/button';
import Col from 'antd/lib/col'; import Col from 'antd/lib/col';
@ -10,7 +11,6 @@ import Form, { RuleObject } from 'antd/lib/form';
import { FormListFieldData, FormListOperation } from 'antd/lib/form/FormList'; import { FormListFieldData, FormListOperation } from 'antd/lib/form/FormList';
import Input from 'antd/lib/input'; import Input from 'antd/lib/input';
import Row from 'antd/lib/row'; import Row from 'antd/lib/row';
import notification from 'antd/lib/notification';
import Tooltip from 'antd/lib/tooltip'; import Tooltip from 'antd/lib/tooltip';
import config from 'config'; import config from 'config';
@ -22,8 +22,6 @@ interface Props {
export default function ManifestsManager(props: Props): JSX.Element { export default function ManifestsManager(props: Props): JSX.Element {
const { form, manifestNames, setManifestNames } = props; const { form, manifestNames, setManifestNames } = props;
const maxManifestsCount = useRef(5);
const [limitingAddingManifestNotification, setLimitingAddingManifestNotification] = useState(false);
const { DATASET_MANIFEST_GUIDE_URL } = config; const { DATASET_MANIFEST_GUIDE_URL } = config;
const updateManifestFields = (): void => { const updateManifestFields = (): void => {
@ -40,15 +38,6 @@ export default function ManifestsManager(props: Props): JSX.Element {
updateManifestFields(); updateManifestFields();
}, [manifestNames]); }, [manifestNames]);
useEffect(() => {
if (limitingAddingManifestNotification) {
notification.warning({
message: `Unable to add manifest. The maximum number of files is ${maxManifestsCount.current}`,
className: 'cvat-notification-limiting-adding-manifest',
});
}
}, [limitingAddingManifestNotification]);
const onChangeManifestPath = (manifestName: string | undefined, manifestId: number): void => { const onChangeManifestPath = (manifestName: string | undefined, manifestId: number): void => {
if (manifestName !== undefined) { if (manifestName !== undefined) {
setManifestNames(manifestNames.map((name, idx) => (idx !== manifestId ? name : manifestName))); setManifestNames(manifestNames.map((name, idx) => (idx !== manifestId ? name : manifestName)));
@ -56,18 +45,11 @@ export default function ManifestsManager(props: Props): JSX.Element {
}; };
const onDeleteManifestItem = (key: number): void => { const onDeleteManifestItem = (key: number): void => {
if (maxManifestsCount.current === manifestNames.length && limitingAddingManifestNotification) {
setLimitingAddingManifestNotification(false);
}
setManifestNames(manifestNames.filter((name, idx) => idx !== key)); setManifestNames(manifestNames.filter((name, idx) => idx !== key));
}; };
const onAddManifestItem = (): void => { const onAddManifestItem = (): void => {
if (maxManifestsCount.current <= manifestNames.length) { setManifestNames(manifestNames.concat(['']));
setLimitingAddingManifestNotification(true);
} else {
setManifestNames(manifestNames.concat(['']));
}
}; };
return ( return (

Loading…
Cancel
Save