Fixed issue: Uncaught TypeError: this.el.node.getScreenCTM() is null … (#4175)

* Fixed issue: Uncaught TypeError: this.el.node.getScreenCTM() is null in Firefox

* Updated version and changelog

* Fixed test
main
Boris Sekachev 4 years ago committed by GitHub
parent b6f3b05bb1
commit da82f4f0d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -53,6 +53,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Order in an annotation file(<https://github.com/openvinotoolkit/cvat/pull/4087>) - Order in an annotation file(<https://github.com/openvinotoolkit/cvat/pull/4087>)
- Fixed task data upload progressbar (<https://github.com/openvinotoolkit/cvat/pull/4134>) - Fixed task data upload progressbar (<https://github.com/openvinotoolkit/cvat/pull/4134>)
- Email in org invitations is case sensitive (<https://github.com/openvinotoolkit/cvat/pull/4153>) - Email in org invitations is case sensitive (<https://github.com/openvinotoolkit/cvat/pull/4153>)
- Uncaught TypeError: this.el.node.getScreenCTM() is null in Firefox (<https://github.com/openvinotoolkit/cvat/pull/4175>)
- Bug: canvas is busy when start playing, start resizing a shape and do not release the mouse cursor (<https://github.com/openvinotoolkit/cvat/pull/4151>) - Bug: canvas is busy when start playing, start resizing a shape and do not release the mouse cursor (<https://github.com/openvinotoolkit/cvat/pull/4151>)
- Fixed tus upload error over https (<https://github.com/openvinotoolkit/cvat/pull/4154>) - Fixed tus upload error over https (<https://github.com/openvinotoolkit/cvat/pull/4154>)

@ -1,12 +1,12 @@
{ {
"name": "cvat-canvas", "name": "cvat-canvas",
"version": "2.12.1", "version": "2.12.2",
"lockfileVersion": 2, "lockfileVersion": 2,
"requires": true, "requires": true,
"packages": { "packages": {
"": { "": {
"name": "cvat-canvas", "name": "cvat-canvas",
"version": "2.12.1", "version": "2.12.2",
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {
"@types/polylabel": "^1.0.5", "@types/polylabel": "^1.0.5",

@ -1,6 +1,6 @@
{ {
"name": "cvat-canvas", "name": "cvat-canvas",
"version": "2.12.1", "version": "2.12.2",
"description": "Part of Computer Vision Annotation Tool which presents its canvas library", "description": "Part of Computer Vision Annotation Tool which presents its canvas library",
"main": "src/canvas.ts", "main": "src/canvas.ts",
"scripts": { "scripts": {

@ -1947,6 +1947,8 @@ export class CanvasViewImpl implements CanvasView, Listener {
hideText(); hideText();
(shape as any).on('remove.drag', (): void => { (shape as any).on('remove.drag', (): void => {
this.mode = Mode.IDLE; this.mode = Mode.IDLE;
// disable internal drag events of SVG.js
window.dispatchEvent(new MouseEvent('mouseup'));
}); });
}) })
.on('dragend', (e: CustomEvent): void => { .on('dragend', (e: CustomEvent): void => {
@ -2028,7 +2030,11 @@ export class CanvasViewImpl implements CanvasView, Listener {
if (state.shapeType === 'rectangle') { if (state.shapeType === 'rectangle') {
shapeSizeElement = displayShapeSize(this.adoptedContent, this.adoptedText); shapeSizeElement = displayShapeSize(this.adoptedContent, this.adoptedText);
} }
(shape as any).on('remove.resize', resizeFinally); (shape as any).on('remove.resize', () => {
// disable internal resize events of SVG.js
window.dispatchEvent(new MouseEvent('mouseup'));
resizeFinally();
});
}) })
.on('resizing', (): void => { .on('resizing', (): void => {
resized = true; resized = true;

Loading…
Cancel
Save